ashkulz / NppFTP

Plugin for Notepad++ allowing FTP, FTPS, FTPES and SFTP communications
https://ashkulz.github.io/NppFTP/
320 stars 93 forks source link

investigate switch to Windows Build Environment on Travis #247

Closed ashkulz closed 5 years ago

ashkulz commented 5 years ago

We should investigate switching to Windows Build Environment on TravisCI, so that we've got only one CI tool in place. I recently migrated wkhtmltopdf to use that -- see wkhtmltopdf/wkhtmltopdf@c417e511452cf1b68992de107b6b7f1402ec9e0c

chcg commented 5 years ago

Or the other way around as appveyor is supporting linux: https://www.appveyor.com/docs/linux-images-software/

Additionally there would be the option: https://azure.microsoft.com/en-us/services/devops/pipelines/

ashkulz commented 5 years ago

True, I went with Travis CI because it supports all 3 OSes I need (Windows, macOS and Linux) and there's no restriction on the build times -- AppVeyor has a 1 hour timeout. Azure Pipelines was an option as well but didn't really investigate it.

ashkulz commented 5 years ago

@chcg I'm not sure what's going on with the builds -- the Travis CI builds don't update the build status while AppVeyor simply errors out.

chcg commented 5 years ago

@ashkulz There is a "random" error with the python urllib download via appveyor. So typically at least one of the 4 build jobs fails. In this case the build result from travis is not retrieved by github, also the build is running and don't show the download issue. Currently I'm not sure if it is a python version issue or an issue with appveyor itself. I already tried to fix it by changing from deprecated urlretrieve() -> urlopen(), but that didn't change the behaviour. Started to happen with https://ci.appveyor.com/project/ashkulz/nppftp/builds/24874269 and just libssh is affected. Strange.

A different issue I face with the change of travis config from 14.04 -> 16.04. I get linker issues, see: https://travis-ci.org/ashkulz/NppFTP/jobs/552399212 Do you have an idea how to adapt the config for ubuntu xenial to build?

ashkulz commented 5 years ago

I'll look into it in a day or two. Do you wish for us to switch completely to AppVeyor, considering TravisCI is likely to be on auto-pilot for the near future? The tough part will be to migrate the automatic release creation.

ashkulz commented 5 years ago

I fixed the AppVeyor build in #257, will look into the xenial upgrade for TravisCI soon.

ashkulz commented 5 years ago

The Xenial upgrade is done as part of #258 -- both TravisCI and AppVeyor seem to be reporting now on all builds.

ashkulz commented 5 years ago

I think let's just close this ticket for now, and re-look only if there's some pressing need for migration.