ashkulz / NppFTP

Plugin for Notepad++ allowing FTP, FTPS, FTPES and SFTP communications
https://ashkulz.github.io/NppFTP/
322 stars 93 forks source link

NppFTP frequently crashes the entire Npp instance on save/ftp upload. #363

Closed TibTibs closed 11 months ago

TibTibs commented 1 year ago

Description of the Issue

Starting earlier this year, ~Npp 8.5 or maybe a little later my Npp instance started crashing when I save server files. It saves the file locally, and then during connection/upload to the FTP server the instance randomly disappears off screen without warning. When this happens, the local file is saved, but the FTP file is unmodified. At first it was here and there, but lately it's like 2-5 times a day that this happens and it's getting extremely frustrating. I had hoped there would be a bug fix on my last update for Npp and NppFTP, but alas, it's only getting worse it seems. There are no error dialogs or bug reports that I am aware of, so I have no hard data to send. So I will give as many details as possible.

Secondly, this also is happening a little less frequently when trying to expand an FTP folder in the GUI. Double click to open the folder and the console starts showing the steps, and then boom, the window disappears without warning. I keep a good 80 files open at all times, so I don't have to navigate folders that often, or I feel like this would be happening much more often.

A notable thing that I may have changed around the same time and I'm just thinking about now, is enabling Verbose backups. I did this due to slipping off of CTRL+S and hitting CTRL+W while doing a large amount of rollbacks w/ CTRL+Z to find where I messed something up. Of course, closing the file after you rolled back hours of changes is .... painful. So now I have Npp create a backup every time I save a file. I doubt this is the root of anything given the crashes are happening when expanding FTP folders, but it's worth a mention.

image

A new issue that I'm not sure if it's related is files getting deleted from the server, then the save process seems to time out. After which I can save the file dozens of times and it appears to save. Even shows 100% before the action clears the console, but the file never actually uploads to FTP. The only way to save the file on the server at this point is to wait 10+ minutes for what I assume is a connection timeout, or to restart Npp, at which point it instantly works again. Let me know if you want me to create a second bug report for this.

Steps to Reproduce the Issue

  1. Make changes to a file you are editing over FTP.
  2. Save the file numerous times until one time it crashes
  3. Restart Npp, the file is saved locally, but was never uploaded to the server.

Expected Behavior

Save file locally. Changes are uploaded to the FTP server, overwriting the previous file.

Actual Behavior

File saves locally, and then Npp crashes in the process of connecting or uploading the FTP file.

Debug Information

I am just now noticing that I somehow ended up with the 32 bit Npp installed. For now I will refrain from updating to x64 in case you want me to test anything as is.

Notepad++ v8.5.7 (32-bit) Build time : Sep 6 2023 - 23:07:35 Path : C:\Program Files (x86)\Notepad++\notepad++.exe Command Line : Admin mode : OFF Local Conf mode : OFF Cloud Config : OFF OS Name : Windows 11 Enterprise (64-bit) OS Version : 22H2 OS Build : 22621.2283 Current ANSI codepage : 1252 Plugins : ComparePlugin (2.0.2) mimeTools (2.9) NppConverter (4.5) NppExport (0.4) NppFTP (0.29.12)

Basic FTP Port 21 Username and saved PW 30 second timeout Authentication: Try password authentication Transfers: Passive connection / Binary transfer mode Host is a WinHost FTP server

TibTibs commented 11 months ago

For anyone else having this issue, I eventually updated to x64 due to lack of response from anyone else. The crashes have since stopped.

When you search Notepad++ on google it shows a link to download the x64 version. However, when you click it the first download on the page is actually the 32 bit, which is how I ended up with the wrong version in the first place.

While the issue isn't resolved, it seems there aren't enough others having the same issue, so I am going to close the ticket.