search

ashkulz / committers.top

CLI tool which uses the GitHub GraphQL API to rank users according to number of contributions, and corresponding static website.
https://committers.top
MIT License
204 stars 28 forks source link

New Badge #3

Closed fbiego closed 2 years ago

fbiego commented 2 years ago

Is it possible to integrate this badge from commits-top-badge to this project?

![commits.top ranking](https://iot.fbiego.com/api/v1/commits?user=fbiego&country=kenya&bg_color=333333&text_color=77fe89&border_color=89452e)

committers.top ranking

ashkulz commented 2 years ago

@fbiego I'm not sure which of the options below you meant:

  1. mention the above markdown as an alternative in the generated site
  2. actually generate the badge itself via the CF Worker

If it's option 1, I'm not averse to linking to a landing page on your site which allows a user to build the badge.

If it's option 2, I think I like the current badge a bit more, yours feels too big. I'm not averse to loading it if given a variant=XXX query string and from the above URL, but I'm not sure about the uptime of your site (btw, why isn't the URL HTTPS?) as compared to shields.io. I'd have preferred to generate the SVG directly from the worker, but I wasn't sure about the widths etc and just pushed the problem elsewhere :slightly_smiling_face:

ashkulz commented 2 years ago

Please re-open if you can respond to the above comment, as I'm not sure what needs to happen here