ashleawalker29 / ptcg_inventory

http://ptcg-inventory.herokuapp.com/index
1 stars 0 forks source link

Backfilled Tests #41

Closed ashleawalker29 closed 4 years ago

ashleawalker29 commented 4 years ago

Description

Backfilled django unittests to bring code coverage to 100%.

Related Issue

Closes #27.

Motivation and Context

This change ensures that basic functionality works as intended. If this basic functionality ever fails, someone will know before a breaking-change is pushed into production.

How Has This Been Tested?

This has been tested manually, as well as by the GitHub Actions workflow. Code coverage percentage has been tested by CodeCov, see the attached comments on this PR by CodeCov.

Types of changes

Checklist:

codecov-commenter commented 4 years ago

Codecov Report

Merging #41 into master will increase coverage by 11.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           master       #41       +/-   ##
============================================
+ Coverage   88.88%   100.00%   +11.11%     
============================================
  Files           8         8               
  Lines          81        89        +8     
============================================
+ Hits           72        89       +17     
+ Misses          9         0        -9     
Flag Coverage Δ
#unittests 100.00% <100.00%> (+11.11%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
card_inventory/tests.py 100.00% <100.00%> (ø)
ptcg_inventory/settings.py 100.00% <100.00%> (+8.33%) :arrow_up:
card_inventory/views.py 100.00% <0.00%> (+21.42%) :arrow_up:
card_inventory/apps.py 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb42db7...c2964ad. Read the comment docs.