ashley1982 / harviewer

Automatically exported from code.google.com/p/harviewer
0 stars 0 forks source link

Entries are not sorted in Chrome #73

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Download the attached HAR file.
2. View it in the online HAR viewer 2.0.15 
(http://www.softwareishard.com/har/viewer/), under Google Chrome

What is the expected output? What do you see instead?
The expect output would be the entries, sorted by startedDateTime. Instead, 
they are out of order.

What version of the product are you using? On what operating system?
HAR viewer 2.0.15, online, running under Google Chrome 17.0.963.78.

Please provide any additional information below.
HAR viewer works as intended under Firefox. This seems to be related to Issue 
68.

Please attach a HAR file that can be used to reproduce the problem.

Original issue reported on code.google.com by brunon...@brunonery.com on 16 Mar 2012 at 9:42

Attachments:

GoogleCodeExporter commented 9 years ago
The patch in Issue 68 fixes this for me too. The function passed to array.sort 
should normally return an integer (f(a, b) should be less than zero if a < b, 
equal to zero if a == b and bigger than zero if a > b), but in harModel.js it 
returns a boolean (true if a > b, false if a <= b). For some reason, Firefox is 
able to work with both types of function while Google Chrome only works 
correctly with the first one. :P

Original comment by brunon...@brunonery.com on 16 Mar 2012 at 10:06

GoogleCodeExporter commented 9 years ago
Even using a HAR file with sorted entries (attached), Chrome still gives the 
same (weird sorting) results. The patch in Issue 68 doesn't seem to fix it in 
this case.

Original comment by brunon...@brunonery.com on 16 Mar 2012 at 12:45

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch!

Committed at:
https://github.com/janodvarko/harviewer/commit/ffcc2e5709f7d178f8fc5da6edf1f7125
777b4e7

Note that the source code is now maintained on github.com
https://github.com/janodvarko/harviewer/

The issue list is still here for now.

The patch will be included in HAR Viewer 2.0.16

Honza

Original comment by odva...@gmail.com on 17 Mar 2012 at 3:08

GoogleCodeExporter commented 9 years ago
Issue 68 has been merged into this issue.

Original comment by odva...@gmail.com on 17 Mar 2012 at 3:08