ashleychontos / pySYD

automated measurements of global asteroseismic parameters
https://pysyd.readthedocs.io
MIT License
25 stars 13 forks source link

replace int(oversampling_factor) with round(oversampling_factor) #46

Closed MaryumSayeed closed 1 year ago

MaryumSayeed commented 1 year ago

Relevant Materials

Description

The int() function around oversampling_factor causes oversampling_factor to be 0 if it's less than 1 crashing the code. Solution: replace int() with round().

Computing

Please provide (by editing) the following information:

Attachments

In order to reproduce the issue from our end, please provide both the light curve and power spectrum for the relevant target!
Attach the required data files here and if applicable, any figures or screenshots to help explain your problem.

Other

Add any other relevant information here (e.g., links to related issues or solutions) See highlighted line in code: https://github.com/ashleychontos/pySYD/blob/master/src/pysyd/target.py#L365-L371

Summary Checklist:



ashleychontos commented 1 year ago

This is now fixed in pysyd v6.10.5