ashleydw / lightbox

A lightbox gallery plugin for Bootstrap
http://ashleydw.github.io/lightbox
MIT License
1.84k stars 1.3k forks source link

Add an option to skip showLoading() call #162

Closed donlzx closed 8 years ago

donlzx commented 8 years ago

First of all, nice work!

When navigating through a gallery, I notice very fast flickering of the modal box:

All these happen in less than a tenth of second, since the images are already cached by the browser. The visual effect is that underlying page content is mixed with the gallery images.

If the call to showLoading() is skipped,

https://github.com/ashleydw/lightbox/blob/master/ekko-lightbox.coffee#L151

the dialog box flickering does not happen.

ashleydw commented 8 years ago

I wonder if it couldn't be smarter and determine if the next item is already preloaded (or can't be loaded; as in videos, remote urls etc).

ashleydw commented 8 years ago

This is fixed in the latest https://github.com/ashleydw/lightbox/issues/166