search

ashleydw / lightbox

A lightbox gallery plugin for Bootstrap
http://ashleydw.github.io/lightbox
MIT License
1.85k stars 1.3k forks source link

lightbox jQuery 3.1.0 bug #202

Closed Krystus closed 8 years ago

Krystus commented 8 years ago

Recently I found bug when using jQuery 3.1.0. Lightbox takes max width and scale up to specyfic image width in modal window. With 3.1.0 jQuery your lightbox don't add that style settings to the modal-dialog.

jQuery 2.2.4 screen shot 2016-08-03 at 14 38 05

jQuery 3.1.0 screen shot 2016-08-03 at 14 38 57

lbausch commented 8 years ago

Can't we just use return image.on('load', function() { .. }); ?

ashleydw commented 8 years ago

Can you grab the latest files from /dist in this branch. This is a complete re-write, please take note of the new documentation.

https://github.com/ashleydw/lightbox/tree/v4_0_1_jquery3_bootstrap4

Two breaking changes (in readme):

navigate_left and navigate_right functions are camelCased gallery_parent_selector has been deprecated - document.body is default

ashleydw commented 8 years ago

continue this in #166

AndersDJohnson commented 7 years ago

@lbausch This bug is still present in 4.0.2 - would you consider a maintenance branch for the 4.x version and accept a pull request replacing .load( with .on('load', where appropriate, then release as 4.0.3? Or at least update its bower.json to specify jquery@2 as a dependency?

lbausch commented 7 years ago

@adjohnson916 I'm not a maintainer of this project.

ashleydw commented 7 years ago

anyone is welcome to make a 4.0.3 PR to fix the load bug (@adjohnson916)