search

ashleydw / lightbox

A lightbox gallery plugin for Bootstrap
http://ashleydw.github.io/lightbox
MIT License
1.85k stars 1.3k forks source link

Update jQuery load call to use .on() #229

Closed ryanjafari closed 7 years ago

ryanjafari commented 7 years ago

v4.0.2 (for use with Bootstrap 3) was throwing a JS console error when loading a lightbox with an image in it; error described in this Stack article. Using .on('load') instead of .load resolves it.

ashleydw commented 7 years ago

Great! For some reason, I can't see the "Files changed" in the PR. Can you confirm it was just this 1 commit? https://github.com/ashleydw/lightbox/pull/229/commits/1f79fca7dea6a6bbe796b78d0bcc9fecd156d0d5

ryanjafari commented 7 years ago

That's correct Ashley. The other commit you see there, https://github.com/ashleydw/lightbox/pull/229/commits/86d8de213a73f40e38a309431ee18245e7c10d9f, is a merge commit that is blank. I believe you ended up removing the files I changed in https://github.com/ashleydw/lightbox/pull/229/commits/1f79fca7dea6a6bbe796b78d0bcc9fecd156d0d5 in future commits, so the merge commit was cleanly merged in, as the only "conflicts" were that those files were removed. I simply made sure to acknowledge the removal in that merge commit, so it shows nothing.

Since I'm using a tag that references an earlier commit (v4.0.2) these changes would only be for those in a similar situation, as they are made irrelevant by future versions.

ashleydw commented 7 years ago

Try v5.1.0 which is now BS3 compatible