Bower references incorrect bootstrap version

ashleydw / lightbox

A lightbox gallery plugin for Bootstrap

http://ashleydw.github.io/lightbox

MIT License

1.85k stars 1.31k forks source link

Bower references incorrect bootstrap version #242

Open kralmichal opened 7 years ago

kralmichal commented 7 years ago

If you don't have bootstrap already loaded via custom bower.json, then bower downloads latest bootstrap that satisfies ">= 4.0.0-alpha.3" which is currently 4.0.0-alpha.6. Since Alpha 6 was rewritten a lot it breaks website. To be safe you have to load correct version manually. Why even build library on alpha version of another library?

ashleydw commented 7 years ago

you're correct, that's a mistake in the bower file.

I don't understand your question regarding an alpha version.

Feel free to open a pr fixing the bower file

kralmichal commented 7 years ago

I'll probably send a PR over the weekend.

The comment regarding an alpha version is that IMHO building library with dependency on library still in alpha is not right.

ashleydw commented 7 years ago

great 👍

you can use BS3 if you prefer, it is backwards compatible

zxz19 commented 7 years ago

I hava a problem use BS3.3: Uncaught TypeError: modal.handleUpdate is not a function