Closed joemaller closed 7 years ago
I think it's for a minimum/default size, you can change it in options or with data-width
@Turqueso Doesn't work. Vimeo's width is hard-coded to 500px. If we change line 378 to match the other two it works:
let width = this._$element.data('width') || 612
I'm testing this to see if there's something I'm not understanding. Minor as it is, I'll have a PR shortly.
Actually it's already there. #239 is exactly what I was going to do. Can we get that merged?
Fixed in 92693291cc9c1cc52d085b1. Thanks!
👍 Once I've figured out #244 I'll release this fix
Is there some reason why the Vimeo modals have their size hard-coded to 500px (line 378)? Both
_showYoutubeVideo
(line 367) and_showInstagramVideo
(line 385) use the data-width value before falling back.Am I missing something or might this just be an oversight?