Incorrect project in .podspec related to new Privacy Manifest requirement

ashleymills / Reachability.swift

Replacement for Apple's Reachability re-written in Swift with closures

MIT License

7.94k stars 948 forks source link

Incorrect project in .podspec related to new Privacy Manifest requirement #408

Closed SethBaldwin closed 6 months ago

SethBaldwin commented 7 months ago

https://github.com/ashleymills/Reachability.swift/blob/c01127cb51f591045696128effe43c16840d08bf/ReachabilitySwift.podspec#L21

Wondering if this should be s.resource_bundles = {"ReachabilitySwift" => ["Sources/PrivacyInfo.xcprivacy"]}?

@tommyming

tommyming commented 7 months ago

@SethBaldwin thanks for finding this out!

Yes, you are correct, I mainly work on SPM at that PM, so I haven't checked on the cocoapods side thoroughly, sorry for that. Maybe you can create a PR real quick for the maintainer to merge?

Please also double-check if there are any mistakes made by me on Package.swift.

Thanks again!

SethBaldwin commented 7 months ago

I'm just noticing there is already a PR open for this change... https://github.com/ashleymills/Reachability.swift/pull/402