search

ashleymills / Reachability.swift

Replacement for Apple's Reachability re-written in Swift with closures
MIT License
7.94k stars 948 forks source link

Fix privacy report generation #413

Closed adzerjitchii closed 5 months ago

adzerjitchii commented 5 months ago

Adds empty items to CollectedDataType and APITypes

Before:

Screenshot 2024-04-15 at 10 56 55

After:

Screenshot 2024-04-15 at 10 44 57
SagarSDagdu commented 5 months ago

Hi @adzerjitchii , what tool are you using to generate the above errors?

adzerjitchii commented 5 months ago

Xcode, archive your project and then right-click on it, you'll see generate privacy report

SagarSDagdu commented 5 months ago

@adzerjitchii Please add @ashleymills as the reviewer to this PR and let's get this merged, as this is a blocking issue

adzerjitchii commented 5 months ago

@SagarSDagdu can't, only the owner/ contributor with write access can add reviewers 😄

ashleymills commented 5 months ago

@adzerjitchii Thank you for this - I'll merge and create a new release later today

SagarSDagdu commented 5 months ago

@SagarSDagdu can't, only the owner/ contributor with write access can add reviewers 😄

yeah, that is why I asked you to add the owner of this repo as a reviewer for this PR. Anyways I think Ashley has taken a note of this.