ashmanix / blur-filter-obs-plugin

A video source blur filter for OBS
GNU General Public License v2.0
27 stars 4 forks source link

Fail to build on i386 #10

Open eribertomota opened 11 months ago

eribertomota commented 11 months ago

Hi @ashmanix,

I am trying to send version 1.0.1 to Debian. The build in a fresh jail at Salsa.debian.org produces the following errors on i386 (32-bit) architecture:

[ 70%] Building CXX object CMakeFiles/ashmanix-blur-filter.dir/src/filters/simple-gaussian.cpp.o
/usr/bin/ccache /usr/lib/ccache/c++ -DHAVE_OBSCONFIG_H -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DSIMDE_ENABLE_OPENMP -Dashmanix_blur_filter_EXPORTS -I/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/obj-i686-linux-gnu -I/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir -I/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/obj-i686-linux-gnu/ashmanix-blur-filter_autogen/include -I/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src -isystem /usr/include/obs -isystem /usr/include/i386-linux-gnu/qt5 -isystem /usr/include/i386-linux-gnu/qt5/QtCore -isystem /usr/lib/i386-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/i386-linux-gnu/qt5/QtWidgets -isystem /usr/include/i386-linux-gnu/qt5/QtGui -g -O2 -ffile-prefix-map=/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -fopenmp-simd -fno-strict-aliasing -Wdeprecated-declarations -Wempty-body -Wenum-conversion -Werror=return-type -Wextra -Wformat -Wformat-security -Wno-conversion -Wno-float-conversion -Wno-implicit-fallthrough -Wno-missing-braces -Wno-missing-field-initializers -Wno-shadow -Wno-sign-conversion -Wno-trigraphs -Wno-unknown-pragmas -Wno-unused-function -Wno-unused-label -Wparentheses -Wshadow -Wuninitialized -Wunreachable-code -Wunused-parameter -Wunused-value -Wunused-variable -Wvla -Wconversion -Wfloat-conversion -Winvalid-offsetof -Wno-overloaded-virtual -Wno-error=maybe-uninitialized -Winfinite-recursion -fPIC -Werror -MD -MT CMakeFiles/ashmanix-blur-filter.dir/src/filters/simple-gaussian.cpp.o -MF CMakeFiles/ashmanix-blur-filter.dir/src/filters/simple-gaussian.cpp.o.d -o CMakeFiles/ashmanix-blur-filter.dir/src/filters/simple-gaussian.cpp.o -c /builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/filters/simple-gaussian.cpp
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp: In static member function 'static void BlurFilterSource::ChangeFilterSelection(filter_data*, obs_data_t*)':
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp:39:41: error: conversion from 'long long int' to 'std::vector<std::unique_ptr<BaseFilter> >::size_type' {aka 'unsigned int'} may change value [-Werror=conversion]
   39 |                 filterData->filterArray[filterIndex]->GetShaderFilePath();
      |                                         ^~~~~~~~~~~
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp:49:33: error: conversion from 'long long int' to 'std::vector<std::unique_ptr<BaseFilter> >::size_type' {aka 'unsigned int'} may change value [-Werror=conversion]
   49 |         filterData->filterArray[filterIndex]->SetParameters(filterData->effect);
      |                                 ^~~~~~~~~~~
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp: In static member function 'static void* BlurFilterSource::CreateSource(obs_data_t*, obs_source_t*)':
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp:68:45: error: conversion from 'long long int' to 'std::vector<std::unique_ptr<BaseFilter> >::size_type' {aka 'unsigned int'} may change value [-Werror=conversion]
   68 |         filterData->filterArray[filterData->selectedFilterIndex]->UpdateFilter(
      |                                 ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp: In static member function 'static void BlurFilterSource::UpdateSource(void*, obs_data_t*)':
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp:99:33: error: conversion from 'long long int' to 'std::vector<std::unique_ptr<BaseFilter> >::size_type' {aka 'unsigned int'} may change value [-Werror=conversion]
   99 |         filterData->filterArray[blurTypeIndex]->UpdateFilter(settings);
      |                                 ^~~~~~~~~~~~~
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp: In static member function 'static bool BlurFilterSource::FilterSelectionChangeCallback(void*, obs_properties_t*, obs_property_t*, obs_data_t*)':
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp:119:59: error: conversion from 'long long int' to 'size_t' {aka 'unsigned int'} may change value [-Werror=conversion]
  119 |                         obs_property_list_item_name(list, selectedFilterIndex));
      |                                                           ^~~~~~~~~~~~~~~~~~~
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp: In static member function 'static void BlurFilterSource::RenderSource(void*, gs_effect_t*)':
/builds/debian/obs-ashmanix-blur-filter/debian/output/source_dir/src/blur-filter-source.cpp:181:33: error: conversion from 'long long int' to 'std::vector<std::unique_ptr<BaseFilter> >::size_type' {aka 'unsigned int'} may change value [-Werror=conversion]
  181 |         filterData->filterArray[filterIndex]->Render(context);
      |                                 ^~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [CMakeFiles/ashmanix-blur-filter.dir/build.make:107: CMakeFiles/ashmanix-blur-filter.dir/src/blur-filter-source.cpp.o] Error 1

Could you check this issue for me? The last version (0.0.2) was built fine on all archs on Debian.

I attached a full log below.

Regards,

Eriberto

blur-werror.txt.gz

eribertomota commented 11 months ago

Using --compile-no-warning-as-error is a workaround for this issue. However, could you fix the problem?