search

ashmckenzie / highlander

Project Highlander
8 stars 8 forks source link

Use GitHub username for github_push metric #11

Closed stuliston closed 11 years ago

stuliston commented 11 years ago

We had to introduce a GitHub username field in order to support the new issues integration in #10.

For consistency, we should use this field the match pushes to the correct user, too.

ashmckenzie commented 11 years ago

Absolutely, great idea. Perhaps we should take advantage of Postgres' HSTORE extension and store this sort of thing as a key / value pair ? Thinking of Highlander usage beyond our needs.. think Bitbucket instead of GitHub etc

stuliston commented 11 years ago

Interesting, yeah. So like this?

Usernames:

{ Github: 'stuliston', Bitbucket: 'sliston' }

I guess the other thing we have to make sure is that we authorise the use of usernames before we open it up. Right now there's nothing stopping me putting anyone's GitHub username in there...

On Sunday, April 14, 2013, Ash McKenzie wrote:

Absolutely, great idea. Perhaps we should take advantage of Postgres' HSTORE extension and store this sort of thing as a key / value pair ? Thinking of Highlander usage beyond our needs.. think Bitbucket instead of GitHub etc

— Reply to this email directly or view it on GitHubhttps://github.com/ashmckenzie/highlander/issues/11#issuecomment-16350209 .

ashmckenzie commented 11 years ago

Something along those lines. There's the concept of User and User attributes which could be a long list depending on how many API services are hooked up. Either HSTORE of a UserAttribtues or something (not as nice though).

Just noticed your update magically appeared.. GH Issues supports sockets! Nice!