Open am11 opened 3 years ago
Thanks for reporting! I think for both this and your PR I'll likely do some kind of "asm improvement"-focused milestone to take a look at the problem as a whole and all improvements. Can't promise a specific timeline yet though.
A few suggestions for labels in ASM, which I think may improve end user experience:
{PC/IP - current method's address}
and jumps in resolver are based on{current method's address - given token's address}
. We can use a global counter to increment the labels nicely.offset flat:L123
.Mainly inspired by godbolt's presentation of Intel syntax: https://godbolt.org/z/srsnvbPW3 vs. https://sharplab.io/#gist:bdd34fbf887666b8ad8c2af70044ef7c (both 32-bit for easy comparison, since symbol resolver for RyuJIT x64 is disabled atm due to another issue).
Aside: I was looking at ways to implement label navigation in ASM viewer. These suggestions, if implemented, will also make it easier to provide that feature, i.e. click on jump label to go-to its declaration as godbolt provides, but better: if it is outside of visible window scroll-to the declaration region.