search

ashmind / mirrorsharp

MirrorSharp is a code editor <textarea> built on Roslyn and CodeMirror
BSD 2-Clause "Simplified" License
220 stars 39 forks source link

update API surface area for FCS 40 #171

Closed baronfel closed 3 years ago

baronfel commented 3 years ago

This updates to FCS 40 for F# 5.0 syntax support, in addition to adapting to a few API usage differences as the team has standardized terminology and pulled a few APIs off of the Reactor thread.

baronfel commented 3 years ago

There are a few test failures, but I don't see anything related to FSharp in the stack traces, any pointers here?

ashmind commented 3 years ago

Thank you for your work! The build failure is just bad luck, I've broken the main build just before you submitted this -- please try rebasing on latest main.

Minor suggestions (not a blocker for merge, I can do that after):

  1. If you update <VersionPrefix>0.20</VersionPrefix> in FSharp.csproj to 0.21 it will get published to NuGet automatically once I merge it
  2. If you do 1, please also update CHANGELOG.md accordingly
baronfel commented 3 years ago

Thanks for the pointers, I'll get right on them.

baronfel commented 3 years ago

And all green now, thanks again for the pointers.

ashmind commented 3 years ago

Thanks!