ashmind / mirrorsharp

MirrorSharp is a code editor <textarea> built on Roslyn and CodeMirror
BSD 2-Clause "Simplified" License
220 stars 39 forks source link

When updating MirrorSharp breaks #219

Closed Sicos1977 closed 1 year ago

Sicos1977 commented 1 year ago

When updating to version 4.6 on one of the component below MirrorSharp breaks. I don't get any error but the communication from codemirror fails and complains about websocket state 3

image

Sicos1977 commented 1 year ago

Thanks for fixing....

Also just another question. Is there a timeline when an official release will be there for codemirror 6? Is see that you have added some very nice new features like code completion that are not in mirrorsharp in combination with codemirror 5.

ashmind commented 1 year ago

The fix for this issue is included in https://www.nuget.org/packages/MirrorSharp.Common/3.0.6 (just released).

As for CodeMirror 6, there is no specific timeline -- it should be mostly stable already but there are still a bit of edge cases to investigate, and I wasn't actively looking at them for a while.

There should be no completely new features though, just changes to how features are presented. Code completion should already work in CM5 (though CM6 might be more reliable in mobile browsers).

Sicos1977 commented 1 year ago

The fix for this issue is included in https://www.nuget.org/packages/MirrorSharp.Common/3.0.6 (just released).

As for CodeMirror 6, there is no specific timeline -- it should be mostly stable already but there are still a bit of edge cases to investigate, and I wasn't actively looking at them for a while.

There should be no completely new features though, just changes to how features are presented. Code completion should already work in CM5 (though CM6 might be more reliable in mobile browsers).

What I mean with code completion is functionality like this

image

and

image

I never have seen that in the current implementation I have with codemirror 5

I only see this

image