Open bryce-carson opened 3 months ago
Thanks, I will fill out this form (https://rasterra.com/contact/gadm_contact_form) and seek permission.
Thanks, I will fill out this form (https://rasterra.com/contact/gadm_contact_form) and seek permission.
Okay. For the future, you prefer that we distribute the files (if we are given permission) rather than download them on demand? The difference between the two is that:
If we aren't given permission, then we must use solution two regardless.
GADM servers are unreliable. I have experienced it during holidays and late late nights. I prefer we give this along with the code.
GADM servers are unreliable.
That's unfortunate. Alright; we'll hope we are given permission.
@Toby-exe, while this ticket is unresolved, I think it's alright if we validate the uploaded coordinate data using the rnaturalearth package; that package is fully open-source, so there's no licensing issue. Conveniently, you've already completed the work for #5 & #25 when the vector/polygon data is taken from the rnaturalearth package.
Can you push those changes (before you began hacking on them further to enable use of GADM data) to the unstable branch on the GitHub remote?
@ashokkrish, while we wait for a reply from the people who administrate and contribute to GADM, we should consider switching all of our vector data to use the rnaturalearth package. I read a small, limited blog post about various terrestrial vector data packages, and it looks like rnaturalearth has the benefit of being fully open source so we don't need to worry about a licensing issue.
Although, we are Canadian, so we're afforded some extra protections by our copyright laws; however, using GitHub, a U.S.-based company, to redistrubute the GADM files may pose some issues. Can you speak with the copyright office at Mount Royal to get some advice?
The simplest solution is hope we're given license by the GADM people, and have @Toby-exe resolve #5 and #25 with rnaturalearth only. The next simplest solution is to let @Toby-exe continue to hack on his solution to those issues and present one that will work without the rnaturalearth package. The most complex solution is to change all of our spatial vector data sources to rnaturalearth.
@ashokkrish Any response from the GADM folks yet?
I took a look at OpenStreetMap, and it has rather details administrative boundary data for the DRC, at least. It's license is compatible. We could use their database, which has an open license. It's a huge file, however. We could filter the database down to only what we need and redistribute that, perhaps.
Problem
@ashokkrish, according to the license of GADM data, we aren't allowed to redistribute the shape files (*sp_1.rda) without receiving prior permission to do so. I imagine this is frequently violated by users of GADM because they haven't read the license terms for the data. Have you received prior permission to do so, or should I modify spatialEpisim to download the data on demand on the user's machine, rather than these files being redistributed with spatialEpisim and increasing its download requirements (currently downloading spatialEpisim will require you to download the shapefiles for all countries, even if you're only interested in one).
Quoted from a License file included in a ZIP of a shapefile downloaded from https://www/gadm.org/
See https://www.gadm.org/license.html for the license that applies to all formats, which imposes the same restrictions.
Alternative solutions to the problem
One
Either you've already contacted the GADM copyright holders and received prior permission to redistribute the files to suit our purposes, or you should do so that we may continue to redistribute them without continuing to violate their license.
Two