search

ashokkrish / spatialEpisim

spatialEpisim: Spatial Tracking of Infectious Disease Epidemics using Mathematical Models
GNU General Public License v3.0
9 stars 5 forks source link

Switch spatialEpisim to have a top ribbon to be within the Krishnamurthy Lab #56

Closed ashokkrish closed 3 weeks ago

ashokkrish commented 4 weeks ago

@bryce-carson

In the episim app we have

image

The same way for the spatialEpisim app I want this

image

to be replaced with

The Krishnamurthy Lab Spatio-Temporal Epidemic Modelling app

Can you do this switch on the main branch by the end of the week so I can deploy it to the ShinyApps.io server?

ashokkrish commented 3 weeks ago

@bryce-carson Will you be able to get this issue closed in the next 1 or 2 days?

bryce-carson commented 3 weeks ago

@bryce-carson Will you be able to get this issue closed in the next 1 or 2 days?

I believe so. It's a small item.

bryce-carson commented 3 weeks ago

https://github.com/ashokkrish/episim/blob/aff27354812943b25f1d41f31f7bf3a764804291/ui.R#L367-L375

I'm going to try inserting this into the UI and if it looks alright I'll push it. It might not integrate well because the UI in spatialEpisim's main branch is constructed differently than Episim's.

bryce-carson commented 3 weeks ago

@ashokkrish, the change is accomplished; the UI overall is still in a bad state but not worth reconstructing at this late stage when the UI is already being overhauled in the refactored branch.

ashokkrish commented 3 weeks ago

@bryce-carson Thanks for the update. I didn't know the UI is being overhauled in the refactored branch. I was under the impression that the current UI is quite solid and you are basically going to connect package with the existing UI. I'd love to see the new UI preview if available.

bryce-carson commented 3 weeks ago

@bryce-carson Thanks for the update. I didn't know the UI is being overhauled in the refactored branch. I was under the impression that the current UI is quite solid and you are basically going to connect package with the existing UI. I'd love to see the new UI preview if available.

The UI is staying the same for the most part. I want to play with a stepped wizard, but that's just an idea and a lot of trouble to implement right now.

The UI is staying the same in effect and appearance, but just rewritten so it is clean and organized.