ashqal / MD360Player4Android

It is a lite library to render 360 degree panorama video for Android. VR Player.
Apache License 2.0
1.08k stars 357 forks source link

video flipped upside-down with gradle 4.0+ #203

Open davibe opened 7 years ago

davibe commented 7 years ago

I am creating an android library that uses exoplayer + md360player4android. The library has its own unit test but in the same project i also have a separate module which includes the library into a sample app. When i run the unit tests the video is fine. When i run the sample app the video is shown upside down.

This only happens if i use android studio + gradle 4.0+ If i downgrade to gradle 2.3.3 all the video views are displayed correctly. Note that only the video is flipped, all other views are ok. When i say flipped i mean that it is flipped upside down but not left-right. The images on the left part of the video are still on the left when it's displayed upsidedown. This has nothing to do with display orientation (which would rotate the video)

I am using version 03fa4e5e7b4cb7e1e8577f85224440ac0ff553d2

I know this is difficult to track down without the code but my project is not publicly available so this description is the best i can do.

ashqal commented 6 years ago

Please check the res in MD360Player4Android/vrlib/src/main/res/raw/

davibe commented 6 years ago

@ashqal Could you please elaborate a bit how/what could i check ? That directory seems to contain shaders code. I don't understand what could be affected just by upgrading gradle and gradle-wrapper

ashqal commented 6 years ago

@davibe I have tested on gradle 4.1 & gradle plugin 3.0.1, and it is working just fine. Compare with the res/raw/... file between gradle 4.0+ and gradle 2.3.3 in the output .apk file, aapt2 may making some change.

davibe commented 6 years ago

I still have this problem after so much time. I did not upgrade gradle in the past but now I think its time so I have to figure this out somehow.

The .glsl file are the same between the old and the new version. However I did notice that the new version of gradle generates additional *.glsl.flat that are not present in the old version.

I have tried to disable aapt2 (android.enableAapt2=false in gradle.properties) but the video is still flipped upsidedown.

I will try to create a project that reproduces this issue. Do you have any other hint in the meantime ?