search

ashthespy / Atom-LaTeX

The only LaTeX package you need for typesetting with Atom.
https://atom.io/packages/atom-latex
MIT License
22 stars 9 forks source link

icon not rendered correctly #221

Closed newton108 closed 5 years ago

newton108 commented 5 years ago
Screenshot 2019-09-20 at 13 48 59

Happens every time I run the application. Back to normal, occasionally, after the theme is changed to a different one and changed back. Any idea how this happened?

ashthespy commented 5 years ago

@newton108 More info about version of Atom/OS etc?

newton108 commented 5 years ago

@newton108 More info about version of Atom/OS etc?

Thank you for the reply. Atom version 1.40.1, macOS 10.14.6. It occurred in two separate machine, however I do use iCloud to sync the folder .atom. But I'm quite reluctant to believe that's the problem since anything else works quite well.

ashthespy commented 5 years ago

The fonts being uses should be available in .atom/packages/atom-latex/fonts/ and area loaded simply as:

@font-face {
  font-family: 'FontAwesome';
  font-weight: normal;
  font-style: normal;
  src: url(atom://atom-latex/fonts/fontawesome-webfont.woff2);
}

I am unsure why some fonts seems to be rendering for you, and some don't. Honestly, I wouldn't really know how to debug this..

newton108 commented 5 years ago

The fonts being uses should be available in .atom/packages/atom-latex/fonts/ and area loaded simply as:

@font-face {
  font-family: 'FontAwesome';
  font-weight: normal;
  font-style: normal;
  src: url(atom://atom-latex/fonts/fontawesome-webfont.woff2);
}

I am unsure why some fonts seems to be rendering for you, and some don't. Honestly, I wouldn't really know how to debug this..

Thanks. It seems that the only icon that doesn't render at startup of the application is 'file-text-o'. I'll try to install a fresh copy of Atom and .atom folder and see what's going on.

newton108 commented 5 years ago

OK, I found that this issue is caused by a conflict to the package tool-bar, which also uses FontAwesome. The icon is rendered properly as long as I disable that package. Is there anything you can do here? Otherwise I'm pretty fine with disabling that package, and consider the issue closed.

ashthespy commented 5 years ago

Quite possibly a version issue, as we use a much older version of FontAwesome. You could manually update the ones used here to 5.9.0 by copying across the ones from tool-bar for now, I will in the meantime update the ones.

FWIW: The issue is because file-text-o was renamed to file-alt in the jump from fontawesomev5.

ashthespy commented 5 years ago

I just had a look, and v5 seems to moved to a "Pro" and "Regular" tier. I don't feel particularly up to messing with upgrading for the four icons we use now. I'd recommend opening an issue over at tool-bar asking them to include their v4-shims.css as well.