ashtian01 / optiboot

Automatically exported from code.google.com/p/optiboot
0 stars 0 forks source link

Trivial readability of adaboot no-wait #55

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
This may seem completely stupid and meaningless but when recently composing a 
special purpose sketch uploader, I noticed that all the stk500 "commands" use 
their #define'd constants except the adaboot no-wait mod which uses the literal 
character 'Q'.
http://code.google.com/p/optiboot/source/browse/optiboot/bootloaders/optiboot/op
tiboot.c#510

For the sole purpose of readability, it might be a good idea to replace this 
'Q' with STK_LEAVE_PROGMODE, which is already defined in the source and is the 
intention of why avrdude is sending it.

Original issue reported on code.google.com by capnbry on 25 Jan 2012 at 1:35

GoogleCodeExporter commented 8 years ago
Ok

Original comment by wes...@gmail.com on 26 Jan 2012 at 1:49

GoogleCodeExporter commented 8 years ago

Original comment by wes...@gmail.com on 28 Jan 2012 at 4:54

GoogleCodeExporter commented 8 years ago
http://code.google.com/p/optiboot/source/detail?r=6b6967d5cd1998e214a6a6dd538bd7
516622a499

Original comment by wes...@gmail.com on 1 Feb 2012 at 4:23