search

ashtonmeuser / godot-wasm

Interact with WebAssembly modules from Godot
https://github.com/ashtonmeuser/godot-wasm/wiki
MIT License
197 stars 12 forks source link

MinGW Windows build fails #26

Closed ashtonmeuser closed 1 year ago

ashtonmeuser commented 1 year ago

Requires a change to Wasmer. Spawned from this comment. Dependent on https://github.com/wasmerio/wasmer/pull/3849. Also see https://github.com/WebAssembly/wasm-c-api/pull/182.

fire commented 1 year ago

Can we run a hotpatch process on download? I don't know how long it'll take and I'd like to integrate godot-wasm this weekend into our build system.

ashtonmeuser commented 1 year ago

Yessir. Hotpatch applied in https://github.com/ashtonmeuser/godot-wasm/commit/d8d7f0ec78a86bb1d4497fa30556068c30ba8c7f (Godot 3.x) and https://github.com/ashtonmeuser/godot-wasm/commit/a41d27d433f18c7d086e5e33f1daf1b5bf16c351 (Godot 4.x). Closing this but will loop back once upstream changes land.

fire commented 1 year ago

Awesome!

I really appreciate your work.

fire commented 1 year ago

@ashtonmeuser I think patch might not exist but git apply might

https://git-scm.com/docs/git-apply

We are assuming git exists.

ashtonmeuser commented 1 year ago

I really appreciate your work.

Right back at ya! This project has been massively improved by your feedback!

I think patch might not exist but git apply might. We are assuming git exists.

Huh I was kinda under the assumption that patch would be a safer assumption in an environment using MinGW and would work outside of a repo. We could always hedge our bets with if [ $(command -v patch) ]; then patch -p1 < wasm-mingw.patch; else git apply wasm-mingw.patch; fi.