search

ashtrath / Tokyo-Night

A clean, dark Discord theme that celebrates the lights of Downtown Tokyo at night.
MIT License
89 stars 175 forks source link

Stylus Support #26

Closed dukedotdev closed 1 year ago

dukedotdev commented 1 year ago

Closes #25. This is marked as beta due to not having addon support, but functioning overall. I'll go back and add addons when I'm back at my desktop in the next few days.

ashtrath commented 1 year ago

I'll mark it as a draft until this pr have full compability with addon. Overall good pr! Thanks!

Edit: shoot! accidently spam clicking the draft button...

Lassebq commented 1 year ago

Take a look at https://github.com/catppuccin/discord for reference, if you're planning to add customizable variables

Lassebq commented 1 year ago 
@var select theme "Theme" ["latte:Latte", "frappe:Frappe", "macchiato:Macchiato", "mocha:Mocha*"]
@var select accent "Accent" {"Rosewater": "'rosewater'", "Flamingo": "'flamingo'", "Pink": "'pink'", "Mauve": "'mauve'", "Red": "'red'", "Maroon": "'maroon'", "Peach": "'peach'", "Yellow": "'yellow'", "Green": "'green'", "Teal": "'teal'", "Blue*": "'blue'", "Sapphire": "'sapphire'", "Sky": "'sky'", "Lavender": "'lavender'"}
dukedotdev commented 1 year ago

Took a look at the theme you linked, and it looks like to add customizable variables would require us to have a different file for every option. We'd also need for people to be able to select multiple options, which I'm not sure is even supported, and would bump up the amount of files needed. It looks really good, but unless there's an alternative I think just telling people to fork it and customize it locally would be better.

dukedotdev commented 1 year ago

Customization options are now available, and Stylus support is fully documented in README.md, should be ready for push.

ashtrath commented 1 year ago

Thanks for the good PRs! Merged!