feat: use Buffer.from(Uint8Array) when input string

ashtuchkin / iconv-lite

Convert character encodings in pure javascript.

MIT License

3.08k stars 282 forks source link

Closed kt286 closed 5 years ago

kt286 commented 5 years ago

change Buffer.from(string,encoding) to Buffer.from(Uint8Array)

ashtuchkin commented 5 years ago

not sure I understand the reasoning here. Also why did you remove the warning?

kt286 commented 5 years ago

oh, sorry. I remove it in my local file but I forget to restore

ashtuchkin commented 5 years ago

so what new functionality does this PR add from the users perspective? I don't get it