[dependencies problem] semver is not support Nodejs 4 and below (Solution2)

ashtuchkin / iconv-lite

Convert character encodings in pure javascript.

MIT License

3.08k stars 282 forks source link

[dependencies problem] semver is not support Nodejs 4 and below (Solution2) #228

Closed Tanandara closed 4 years ago

Tanandara commented 4 years ago

Hi Alexander @ashtuchkin ,

As your CI problem, travis problem

I found the problem that causes one of the dependencies was upgraded.

it is semver https://github.com/npm/node-semver/compare/v6.1.2...master .

the latest version of semver is supporting nodejs 6 and higher.

hence I fixed semver version to 6.1.2

build result https://travis-ci.org/Tanandara/iconv-lite/builds/639399377

ashtuchkin commented 4 years ago

Thanks Tanandara! I think it's a good solution for now. I was planning to deprecate support of old node versions in one of the next major iconv-lite versions, but I feel we're not ready for that yet. This diff will make the build green again, which is great!