search

ashtuchkin / iconv-lite

Convert character encodings in pure javascript.
MIT License
3.08k stars 282 forks source link

convert sbcs codec and some tests #255

Closed gyzerok closed 4 years ago

gyzerok commented 4 years ago

Here is the update for SBCS.

My only problem is - I am not sure how to convert sbcs-test.js because it uses iconv and I am not sure what to do with some usages of Buffer there. Maybe it'd be better for you to take a look at this suite?

Otherwise I think everything is there.

gyzerok commented 4 years ago

The test failures seem to be from the stuff in master and are not related to my PR

ashtuchkin commented 4 years ago

Looks like the master is green now, so could you rebase and I'll merge tomorrow.

gyzerok commented 4 years ago

@ashtuchkin rebased on master. All green now.

ashtuchkin commented 4 years ago

Thank you! Note I've added eslint/prettier integration on the latest master, so be sure to rebase if you decide to convert something else.

gyzerok commented 4 years ago

@ashtuchkin this is great news! I was missing prettier in the workflow very much :)

Which codec do you think would be better for me to take? Probably in my case better == simpler to migrate.

ashtuchkin commented 4 years ago

Utf32 or dbcs would be next I guess. Both will require some diving into, so I'd understand if you wouldn't want to spend more time than you planned on it.

On Sat, Jul 18, 2020, 00:00 Fedor Nezhivoi notifications@github.com wrote:

@ashtuchkin https://github.com/ashtuchkin this is great news! I was missing prettier in the workflow very much :)

Which codec do you think would be better for me to take? Probably in my case better == simplier to migrate.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ashtuchkin/iconv-lite/pull/255#issuecomment-660420080, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEZKHNJUSVOPRFMUIRVCBLR4EM5TANCNFSM4O3IWYEQ .