ashtuchkin / u2f

U2F Authentication for Node.js
399 stars 47 forks source link

Add typescript type definitions #7

Open clems4ever opened 7 years ago

clems4ever commented 7 years ago

Add type definitions and a test file in typescript to test the compilation.

npm run build compiles the typescript test file in directory build/ so that you can run it and check everything is working fine.

clems4ever commented 7 years ago

For you information, I've also written the type definitions for the u2f-api npm package that I use in combination with u2f package in my project (https://www.npmjs.com/package/authelia). I will create a pull request soon for u2f-api.

clems4ever commented 6 years ago

Hello @ashtuchkin , did you have time to check the PR?

zcei commented 6 years ago

Out of interest: how does the testing of the typings work? You just have included the .ts file in include section of tsconfig and when it compiles it's correct?

ashtuchkin commented 6 years ago

Sorry for such a long delay!

clems4ever commented 6 years ago

Everything should be fixed now. Sorry for the long delay as well :).