ashual / scene_generation

A PyTorch implementation of the paper: Specifying Object Attributes and Relations in Interactive Scene Generation
Apache License 2.0
187 stars 30 forks source link

Is box_noise_dim not being used? #12

Closed ennauata closed 4 years ago

ennauata commented 4 years ago

Hi,

I could not find the usage of the box_noise_dim attribute in the Model class, is it being used in the code at all? https://github.com/ashual/scene_generation/blob/e4b98ea437329b1a51deb67811e2b6593baa8ff6/scene_generation/model.py#L25

Also, can we expect the model to output different layouts when sampling the same input graph multiple times by running sample_images.py multiple times?

I would appreciate your feedback on this. Best regards.

ashual commented 4 years ago

Hi, As stated in the paper, we've ended up using a normal noise vector just for the masks. Hence, the box_noise_dim attribute is no longer used in the final version. It can be removed.

The final layout is affected by two different things:

These two things give us diverse layouts, as we wanted.

ennauata commented 4 years ago

Now it's very clear to me. Thank you very much for addressing my questions!