ashupp / Streamdeck-vJoy

Map elgato stream deck buttons to vJoy buttons
GNU General Public License v3.0
67 stars 5 forks source link

Step up and step down buttons do not start at axis center or custom value #13

Open imagebuff opened 3 years ago

imagebuff commented 3 years ago

Example 4 axis action buttons configured: 1) Center axis 2) Custom value 3) Step up 4) Step down

Example test sequence: 1) Step down button pressed until axis is near the bottom 10% of the axis range 2) Center axis button is pressed. Axis is now centered. 3) Step up button is pressed. Axis improperly jumps to the bottom 10% value from step 1. AXIS SHOULD STEP UP FROM CENTER.

The same thing happens if a Custom Value button is pressed for step 2 above.

It seems that the Step Up and Step Down functions start from the last axis position from which these specific functions were used instead of the CURRENT axis position (after a center for example). This leads to some extremely jumpy and unexpected axis movement. Any fix would be greatly appreciated as my implementation heavily relies on initial movement from center. This is for a motion simulator. Thanks for your time and attention.

ashupp commented 3 years ago

Hello and thank you very much for posting this issue and the detailed description. You are correct. I just posted a version that fixes this issue. Would be nice if you could confirm if the fix works. See: https://github.com/ashupp/Streamdeck-vJoy/releases/tag/0.0.2.1

Best regards, Alex

imagebuff commented 3 years ago

Thanks a million Alex. I did some testing over the past few days and all looks perfect. The step up / down controls are starting from the current axis position even after a center. Just remembered I forgot to test the same after setting a custom axis value. I will try that this weekend.

The only thing I wish for is the ability to initialize the axis to a custom value on start up. I recognize that is likely impossible before actually hitting a key to activate your program.

Thanks again for the super quick change. Chris