fixed contributions and repositories bug in sidebar of resume

ashutosh-rath02 / git-re

Generate your resume based on your github profile at a click.

https://git-re.vercel.app

Apache License 2.0

64 stars 71 forks source link

fixed contributions and repositories bug in sidebar of resume #207

Closed atharvarekhawar closed 4 weeks ago

atharvarekhawar commented 1 month ago

Related Issue

None

Description

There was a rendering bug in show contributions which is no more and the limit of repositories is increased to 6.

Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist:

[X ] I have performed a self-review of my code
[X ] I have read and followed the Contribution Guidelines.
[X ] I have tested the changes thoroughly before submitting this pull request.
[X ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X ] I have commented my code, particularly in hard-to-understand areas.

Additional context:

Please add appropriate labels while merging, Thank you 😊.

vercel[bot] commented 1 month ago

@atharvarekhawar is attempting to deploy a commit to the lucif3rin's projects Team on Vercel.

A member of the Team first needs to authorize it.

ashutosh-rath02 commented 1 month ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

ashutosh-rath02 commented 1 month ago

@atharvarekhawar Can you share a video with the changes, it would be helpful?

atharvarekhawar commented 1 month ago

@atharvarekhawar Can you share a video with the changes, it would be helpful?

https://github.com/ashutosh-rath02/git-re/assets/113119063/ab20ecbf-f869-4fc2-a9a7-cfd7365795c4

@ashutosh-rath02 now there is no problem while changing show contributions count and contributions are rendered without any glitch , show repositories have been limited to 6 and if user inserts number larger than 6 , still it shows 6 repos.

ashutosh-rath02 commented 1 month ago

Can you explain me the bug again once coz I see only changes, where you changed limit to 6

atharvarekhawar commented 1 month ago

Can you explain me the bug again once coz I see only changes, where you changed limit to 6

The glitch of the contributions was not present when I pulled latest changes and started the application on my local machine , so I just changed the limit to 6.

@ashutosh-rath02

atharvarekhawar commented 4 weeks ago

can you merge the code @ashutosh-rath02

ashutosh-rath02 commented 4 weeks ago

This doesn't fix the problem as provided in the parent issue.

atharvarekhawar commented 4 weeks ago

This doesn't fix the problem as provided in the parent issue.

there is no bug at the current moment in the website which is similar to the parent issue

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
git-re	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2024 4:45am