search

ashutosh-rath02 / git-re

Generate your resume based on your github profile at a click.
https://git-re.vercel.app
Apache License 2.0
64 stars 70 forks source link

[Bug]: Responsiveness for Recent User Slides #285

Closed kshavp closed 13 hours ago

kshavp commented 1 week ago

Is there an existing issue for this?

Describe the bug

Just like other devices, the cards for recent users should align with tab or 786px and above devices.

Expected behavior

At least one card should fit on the screen at a time thus would make it responsive.

Add ScreenShots

image

On which device are you experiencing this bug?

iPhone

Record

ashutosh-rath02 commented 1 week ago

Thank you for creating this issue! 🎉 We'll look into it as soon as possible. In the meantime, please make sure to provide all the necessary details and context. If you have any questions or additional information, feel free to add them here. Your contributions are highly appreciated! 😊

You can also check our CONTRIBUTING.md for guidelines on contributing to this project.

ashutosh-rath02 commented 1 week ago

Can you check the whole website and let me know what all things need fixing? I can give you a level3 for that

kshavp commented 1 week ago

Sure, would need a day or two, I'll craft the fixes as well so that the issue and PR are added on the same day.

kshavp commented 6 days ago

@ashutosh-rath02 Sharing an update

1. Responsiveness for tab-based devices checked, only the Recent User Slides would undergo a fix.

2. Dark Mode: The Hyperlinks are supposed to turn to "text-primary" on hover as they do in Light Mode, but currently not happening in dark mode.*

3. Light Mode: The Labels provided in profile tracking are merged with the background in the light mode, they are fixed and can be seen as follows: image image

4. Made by Ashutosh Rath: The name in this phrase in the footer can be made a hyperlink to your portfolio website.

5. Secondary Links in the Footer: Links such as "Contribute" and "Vote on Product Hunt" should also get covered with hover effect.

Suggestions and Features

  1. The Generate button in dark mode on Form.tsx can have its text color white, as it looks better in contrast to the gray color. image

  2. The Graphs generated on the profile tracking option can be given an option to be saved/downloaded as image.

  3. Auto Complete feature can be added to the Form.tsx while searching for a github username. NOTE: If we directly fetch usernames from github the increase in number of operations can affect website performance, thus we can have a discussion with other contributors regarding the most optimal approach for this feature.

ashutosh-rath02 commented 6 days ago

Makes sense go ahead, auto complete is not required.

ashutosh-rath02 commented 13 hours ago

Hello @kshavp! Your issue #285 has been closed. Thank you for your contribution!