chore: improved github data fetching performance

ashutosh-rath02 / git-re

Generate your resume based on your github profile at a click.

https://git-re.vercel.app

Apache License 2.0

64 stars 71 forks source link

chore: improved github data fetching performance #314

Closed dhairyathedev closed 3 days ago

dhairyathedev commented 5 days ago

Fixes #312

vercel[bot] commented 5 days ago

@dhairyathedev is attempting to deploy a commit to the lucif3rin's projects Team on Vercel.

A member of the Team first needs to authorize it.

ashutosh-rath02 commented 5 days ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

ashutosh-rath02 commented 4 days ago

Hey @dhairyathedev as this will be a change in our API fetching method, will you please provide a detailed documentation on how you made the changes, how to view the fetched data in apollo and all for the new users to get accustomed to it. Attaching a video will be great along with the docs. You can create a new issue and new PR.

dhairyathedev commented 4 days ago

Removed @apollo/client, now it only takes around 5-7 seconds to load the resume page.

dhairyathedev commented 4 days ago

Hey @dhairyathedev as this will be a change in our API fetching method, will you please provide a detailed documentation on how you made the changes, how to view the fetched data in apollo and all for the new users to get accustomed to it. Attaching a video will be great along with the docs. You can create a new issue and new PR.

Hey @ashutosh-rath02 , now I have switched the codebase to traditional graphql api call, I don't think we need a documentation/video for this. What do you say?

ashutosh-rath02 commented 4 days ago

Not in the readme file, you can drop the changes you made here in the PR. I like the PRs to be self defining.

dhairyathedev commented 4 days ago

Changelog

Removed multiple redundant REST API calls affecting performance into a single GraphQL query.
Removed caching since it was unnecessary.
Commented out the old resume template code, which needs a refactor to align with the latest data fetching utility functions. This change is necessary to prevent build failures in the production version.

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
git-re	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 11:12am