ashutosh-rath02 / git-re

Generate your resume based on your github profile at a click.

https://git-re.vercel.app

Apache License 2.0

77 stars 80 forks source link

solves User is rate-limited by GitHub (issue324) #321

Closed Swastik19Nit closed 3 months ago

Swastik19Nit commented 3 months ago

Related Issue

Encountering the "Data is NULL. User is rate-limited by GitHub" error for some usernames.

Description

324

Type of PR

[ X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): ___

Screenshots / videos (if applicable)

Checklist:

[X ] I have performed a self-review of my code
[X ] I have read and followed the Contribution Guidelines.
[X ] I have tested the changes thoroughly before submitting this pull request.
[ X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ X] I have commented my code, particularly in hard-to-understand areas.

Additional context:

The current code checks if userData.name is null or empty to determine if the user is rate-limited. However, this might not be the most reliable method, as some users might genuinely have no name set on their GitHub profile. So it should be changed to userData.username.

vercel[bot] commented 3 months ago

@Swastik19Nit is attempting to deploy a commit to the lucif3rin's projects Team on Vercel.

A member of the Team first needs to authorize it.

ashutosh-rath02 commented 3 months ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Swastik19Nit commented 3 months ago

@ashutosh-rath02

Swastik19Nit commented 3 months ago

@ashutosh-rath02 i dont know whether my pull request is actually related to this issue or not but there is one problem we are encountering "Data is NULL. User is rate-limited by GitHub" error for some usernames which i have debugged . So should i raise an issue for this first?

ashutosh-rath02 commented 3 months ago

@dhairyathedev

dhairyathedev commented 3 months ago

Hey @Swastik19Nit,

319 is not related to this PR.

But, nice catch! You can merge this PR @ashutosh-rath02

ashutosh-rath02 commented 3 months ago

@Swastik19Nit raise an issue so that your PR gets counted under GSSoC

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
git-re	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 26, 2024 11:01am