search

ashutoshgithubs / iemhacks_DEV-G

https://edtech-dev-g-frontend.vercel.app/
MIT License
31 stars 43 forks source link

Potentially fixed the bugs for invalid Email types and about page in … #69

Closed Saket6 closed 4 months ago

Saket6 commented 4 months ago

This commit fixes the issue #68

Issue Title: Invalid email types bug and footer about us page link fix

Type of change ☑️

What sort of change have you made:

Ive added email type as 'email' in place of text. Changed the src of link in footer page to link to the correct about us page

How Has This Been Tested? ⚙️

Ive tested it by running the front end only and testing it manually.

ashutoshgithubs commented 4 months ago

@Saket6 Please mention the issue number

Saket6 commented 4 months ago

@Saket6 Please mention the issue number Issue no is: #68

github-actions[bot] commented 4 months ago

Thank you for submitting this pull request. We will review the changes and get in contact with you as soon as possible.

ashutoshgithubs commented 4 months ago

@Saket6 Please mention the issue number Issue no is: #68

Hi @Saket6 , I observed the issue #68 now , you have not raised this issue and I have not assigned this task to do....and you raised PR w/o getting assigned to you. From the next time, please follow the guidelines. For the time being, I'm pushing your PR in pending state and gonna assign the real person of this issue who raised it first.

Saket6 commented 4 months ago

@Saket6 Please mention the issue number Issue no is: #68

Hi @Saket6 , I observed the issue #68 now , you have not raised this issue and I have not assigned this task to do....and you raised PR w/o getting assigned to you. From the next time, please follow the guidelines. For the time being, I'm pushing your PR in pending state and gonna assign the real person of this issue who raised it first.

Im extremely sorry. Actually im a newbie in this field and didnt know the correct proccedure to do things here..From next time, I'll read the guidelines. Again sorry if i caused you any inconvenience.

ashutoshgithubs commented 4 months ago

@Saket6 Please mention the issue number Issue no is: #68

Hi @Saket6 , I observed the issue #68 now , you have not raised this issue and I have not assigned this task to do....and you raised PR w/o getting assigned to you. From the next time, please follow the guidelines. For the time being, I'm pushing your PR in pending state and gonna assign the real person of this issue who raised it first.

Im extremely sorry. Actually im a newbie in this field and didnt know the correct proccedure to do things here..From next time, I'll read the guidelines. Again sorry if i caused you any inconvenience.

Okay no worries...If the first person remains inactive for 3-5 days then I'll consider your PR. For the time being, comment below the issue #68 showing your approach. Keep learning & keep contributing to this project. Happy coding! :)

ashutoshgithubs commented 4 months ago

Hi @Saket6 PR of the first person of this has been merged successfully. So, I've closed this PR. From the next time please follow the guidelines and in case of any issue, feel free to contact me. Never loose hope & keep contributing. Happy coding :)