ashutoshkrris / TechyWrite-Old

A website to list down available paid writing opportunities for technical writers.
techywrite.vercel.app
MIT License
8 stars 11 forks source link

[feature request]:The SVG fall back image was not implemented in a correct way which makes it hard to work on in the future #22

Closed aadi58002 closed 1 year ago

aadi58002 commented 1 year ago

Is there an existing issue for this?

Describe the feature.

The #21 PR added the source degign of the svg as a .vue file which was not correct way to use it.

Problem/Motivation.

It is hard to understand what is the purpose of the 404.vue file and what it is doing?

Possible Solution/Pitch.

Save the content into a proper svg file in the public folder and then include it with a img tag.

Anything else?

No response

Hacktoberfest

Code of Conduct

github-actions[bot] commented 1 year ago

@aadi58002 Welcome to TechyWrite🥳 Thanks for opening this Issue 🙌, This Will definitely Improve our Project💖.While we are having a look at this. If you want to work on this then,feel free to self-assign and start working on it.📄 Use /assign to self-assign this issue.

ashutoshkrris commented 1 year ago

Hi @aadi58002 Thanks for opening up the issue. Could you also do the same for other icons in the components folder?

aadi58002 commented 1 year ago

/assign

aadi58002 commented 1 year ago

Hi @aadi58002 Thanks for opening up the issue. Could you also do the same for other icons in the components folder?

Ok Sure

ashutoshkrris commented 1 year ago

Cool, assigning it to you!