search

ashutoshvarma / action-cmake-build

Github action for cmake based projects
MIT License
24 stars 10 forks source link

Spaces in configure-options seem to be un-escapable. #231

Open jackjansen opened 2 years ago

jackjansen commented 2 years ago

I need to have a configure-option with a space in it. Specifically, I need to pass something -DXXXX_ROOT=C:/Program Files/XXXX. And I'm actually getting the pathname from an environment variable (with ${{ env.XXXX_DIR }}).

I have tried putting quotes in all sorts of places, but nothing works.

Then I went to the source of action-cmake-build, and saw that in cmake_runner.ts line 73 you're doing a hard split on spaces:

...this._options.extraArgs.extraBuildArgs.split(' ')

I get the impression that no amount of quoting or backslash-escaping or backslash-escaped-quotes that I can think of will get around this...

alexpsound commented 1 year ago

I have the same issue