search

ashutoshvarma / setup-ninja

Set up your GitHub Actions workflow with a specific version of ninja
MIT License
14 stars 7 forks source link

Error: The `add-path` command is disabled. #6

Open EwoutH opened 3 years ago

EwoutH commented 3 years ago

First of all, thanks for writing this Action!

Currently v1.1 fails with the following error:

Error: Unable to process command '::add-path::ninja_bin' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

This is because the add-path command is depreciated by GitHub:

ashutoshvarma commented 3 years ago

That's odd, It should have been fixed in v1.1 It's working fine for me (see https://github.com/ashutoshvarma/libxpdf/runs/1727931056?check_suite_focus=true#logs) Can you share your workflow file as I am not able to reproduce the same ?

EwoutH commented 3 years ago

I think v1.1 isn't published correctly to GitHub Actions. Using @v1 should result in using the most recent minor version (v1.x), so in this case v1.1.

ashutoshvarma commented 3 years ago

Yeah, you are right. Something is indeed wrong with the v1.1 release on the marketplace. I tried re-releasing both tags (v1 and v1.1) but that didn't work. For now, I would recommend sticking with @master as I don't plan to introduce any breaking changes in the future also. Also If you have any idea why this might be happening please feel free to ping. Thanks again!

EwoutH commented 3 years ago

Can you try changing the v1 release to v1.0, if that’s possible?

In the future it would be best to use the full semantic versioning triple, so v1.0.0 instead of v1