Added MSVC build to workflow & Fixed MSVC build issues

ashvardanian / StringZilla

Up to 10x faster strings for C, C++, Python, Rust, and Swift, leveraging SWAR and SIMD on Arm Neon and x86 AVX2 & AVX-512-capable chips to accelerate search, sort, edit distances, alignment scores, etc 🦖

https://ashvardanian.com/posts/stringzilla/

Apache License 2.0

1.92k stars 64 forks source link

Added MSVC build to workflow & Fixed MSVC build issues #109

Closed ashbob999 closed 4 months ago

ashbob999 commented 4 months ago

Just some fixes for building with MSVC

Added MSVC C/C++ build to the windows workflow
Fixed assertion with range_(r)matches::iterator::operator== when comparing iterators from different containers in debug mode
Fixed incorrect /arch flags for MSVC when building stringzilla_test_cpp20_x86_*

ashvardanian commented 4 months ago

Epic, @ashbob999! Thank you!

ashvardanian commented 4 months ago

Ouch. I've rushed merging and now the Windows pipeline fails. @ashbob999, any chance you known why is that?

ashbob999 commented 4 months ago

It's the iterator issue still, since you reverted it back to using begin/end and iterator debugging is enabled for release mode, it now errors.

ashvardanian commented 4 months ago

:tada: This PR is included in version 3.5.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: