search

ashvardanian / StringZilla

Up to 10x faster strings for C, C++, Python, Rust, and Swift, leveraging SWAR and SIMD on Arm Neon and x86 AVX2 & AVX-512-capable chips to accelerate search, sort, edit distances, alignment scores, etc 🦖
https://ashvardanian.com/posts/stringzilla/
Apache License 2.0
1.92k stars 64 forks source link

Swift tests fixed and added #122

Closed Riyazul555 closed 4 months ago

Riyazul555 commented 4 months ago

Hey @ashvardanian do check this PR.....closes issue #77 In this issue

Two additional test cases have been added: testFindLastCharacterNotFromSetWithEmoji: This test ensures that the findLast function works correctly when the set of characters includes emojis. testFindLastCharacterNotFromSetNoMatch: This test verifies the behavior when there is no character that doesn't belong to the provided set. These tests help ensure that the findLast function works correctly and handles different scenarios effectively.

Thanks

Riyazul555 commented 4 months ago

Thanks for the approval @ashvardanian Please merge the PR also Thanks

ashvardanian commented 4 months ago

I need to run the tests first, @Riyazul555 ;)

Riyazul555 commented 4 months ago

I need to run the tests first, @Riyazul555 ;)

Ya sure Take your time @ashvardanian

Riyazul555 commented 4 months ago

Any progress on the tests @ashvardanian ??

ashvardanian commented 4 months ago

@Riyazul555 your tests fail:

StringZilla/swift/Test.swift:63: error: -[StringZillaTests.StringZillaTests testFindLastCharacterNotFromSetWithEmoji] : XCTAssertEqual failed: (" 👋") is not equal to (" ")
Test Case '-[StringZillaTests.StringZillaTests testFindLastCharacterNotFromSetWithEmoji]' failed (0.079 seconds).
ashvardanian commented 4 months ago

I've removed the illformed test, and merged the rest.