search

ashwanthkumar / gocd-build-github-pull-requests

GoCD plugin to build PRs for a Github repo
95 stars 72 forks source link

Material type is confusing #146

Open mrmanc opened 4 years ago

mrmanc commented 4 years ago

Is there a reason that the material type is Github rather than GitHub Pull Requests? I think people have missed it as an option because the difference between Git and Github is so subtle.

ashwanthkumar commented 4 years ago

No specific reason. It's been that way since the day 1 as far as I can recall. Most of us are now used seeing Github material type. I'll keep this issue open for a while, if more users thing it should be renamed.

kuba-lilz commented 4 years ago

While I got used to it by now, I indeed found it very confusing when first using the plugin.

stephen-murby commented 1 year ago

I agree I think this would be a much less confusing material name, I will include a rename in my (work in progress) pull request to filter out draft pull requests from triggering a pipeline run.