Replicated reads and writes using Consistent Hashing

ashwanthkumar / suuchi

सूचि - Toolkit to build Distributed Data Systems

https://ashwanthkumar.github.io/suuchi/

53 stars 12 forks source link

Replicated reads and writes using Consistent Hashing #23

Closed ashwanthkumar closed 8 years ago

ashwanthkumar commented 8 years ago

CHRing#find(key, n) - returns n nodes from the ring closest to the key - can contain duplicates
CHRing#findNUnique(key, n) - returns n unique nodes from the right closest to the key
Changed contract of the Partitioner to return MemberAddress instead of VNode, since VNode is CHRing specific detail
Added few more tests around CHPartitioner and CHRing

Part of #21

codecov-io commented 8 years ago

Current coverage is 62.95% (diff: 68.96%)

Merging #23 into master will increase coverage by 3.97%

@@             master        #23   diff @@
==========================================
  Files            19         22     +3   
  Lines           273        386   +113   
  Methods           0          0          
  Messages          0          0          
  Branches         37         58    +21   
==========================================
+ Hits            161        243    +82   
- Misses          100        125    +25   
- Partials         12         18     +6

Powered by Codecov. Last update 016dec8...c8924a6

brewkode commented 8 years ago

Lets catch up on this before I merge. Hope thats ok.

ashwanthkumar commented 8 years ago

@brewkode Shall I go ahead and merge this?

ashwanthkumar commented 8 years ago

Most of my comments are addressed as part of #27

brewkode commented 8 years ago

@ashwanthkumar Does this need to be merged?

ashwanthkumar commented 8 years ago

@brewkode #27 was merge into this branch so yeah we need to merge this too.

ashwanthkumar commented 8 years ago

@brewkode incorporated the feedback comments from #27 in here. Have one final look at the changes and we can merge it in.

brewkode commented 8 years ago

@ashwanthkumar Merging this!