ashwanthkumar / suuchi

सूचि - Toolkit to build Distributed Data Systems
https://ashwanthkumar.github.io/suuchi/
53 stars 12 forks source link

sbt based project setup #25

Closed ashwanthkumar closed 6 years ago

ashwanthkumar commented 7 years ago

Had to write a lot of boiler plate around protobuf - grpc integration if we don't want to change a lot of things.

I saw ScalaPB but didn't want to generate Scala based classes for the default set of services - at least not yet. So I wrote a wrapper in the build to download the official protoc-grpc-java plugin and execute it as part of the sbt compile phase.

As noted the SbtGrpcJava part should be extracted into a SBT plugin on it's own so folks who don't want to use ScalaPB still has a choice to use the default Java based Services and proto messages.

codecov-io commented 7 years ago

Current coverage is 61.01% (diff: 100%)

Merging #25 into master will increase coverage by 2.03%

@@             master        #25   diff @@
==========================================
  Files            19         19          
  Lines           273        277     +4   
  Methods           0        183   +183   
  Messages          0          0          
  Branches         37         25    -12   
==========================================
+ Hits            161        169     +8   
  Misses          100        100          
+ Partials         12          8     -4   

Powered by Codecov. Last update 016dec8...533ac9a

ashwanthkumar commented 7 years ago

The decrease in coverage is because of the new coverage report from scoverage.

Fixes #18

ashwanthkumar commented 6 years ago

Closing this in favour of #78