ashwanthkumar commented 7 years ago

Support doing Aggregation using Algebird's Aggregator abstraction.

Also made some changes to support maven snapshot publishing from TravisCI. Will send in Docs update in a while. Please go through the changes.

Some problems I've in the current implementation which should be fixed before merging

[ ] While doing scatter we send requests to all the nodes in the cluster (incl. the node that's doing the scatter).
[x] Since we use Futures.allAsList(...).get any failure is not propagated back to us because that's caught by the ExecutorService internally in guava library. Need to find out how to handle and propagate these type of failures.
[ ] Current implementation is for Unary methods only. Need to add support for streaming aggregation as well.

codecov-io commented 7 years ago

Codecov Report

Merging #65 into master will decrease coverage by 1.35%. The diff coverage is 57.4%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
- Coverage      75.7%   74.34%   -1.36%     
- Complexity      121      127       +6     
============================================
  Files            34       36       +2     
  Lines           675      729      +54     
  Branches         79       82       +3     
============================================
+ Hits            511      542      +31     
- Misses           99      121      +22     
- Partials         65       66       +1

ashwanthkumar commented 7 years ago

Merging these changes. Tracking the 2 items as part of #69 and #70.

ashwanthkumar / suuchi

Aggregator support #65

Codecov Report