search

ashwin / coursera-heterogeneous

Resources to work offline on the assignments of Heterogenous Parallel Programming course from Coursera.
71 stars 60 forks source link

ctest #31

Closed simogasp closed 11 years ago

simogasp commented 11 years ago

Hi, first of all thank you very much for this repository, it's been very useful to test the MPs of the course. I think that there may be a bug in the CMakeLists.txt, in the test section. When i run (eg for mp5) ctest -L mp5 -V . my mp runs ok and give the correct results but the testing framework does not recognize that as it cannot find the string "All test passed" (eg. see line 109 of CMakeLists) and so it gives that all the tests have failed. So i guess the string should either changed to "The solution is correct" which is actually the string print by all MPs when everything goes ok, or change the function in include/wb.h so that the string "All test passed" is actually printed at the end of the comparison with the expected output. I quickly tried the first option (change the CMakeLists) and it works.

Thank you!

S.

iemejia commented 11 years ago

Thanks, yes effectively the last changes in the wb.h file broke the test, I just fixed it and submit the pull request, we have to wait for ashwin to apply it.

simogasp commented 11 years ago

Thank you!

S,