search

ashwin3005 / password-generator

Password generator made with React
MIT License
20 stars 38 forks source link

Lowercase checkbox #38

Closed ashwin3005 closed 1 year ago

ashwin3005 commented 1 year ago

The lowercase checkbox must be checked by default.

Ravina-Deogadkar commented 1 year ago

can i take this issue?

ashwin3005 commented 1 year ago

Go ahead..

M-Rahul1 commented 1 year ago

I would like to contribute. Screenshot (15)

M-Rahul1 commented 1 year ago

@Ravina-Deogadkar if you are not doing can I take it. @ashwin3005

ashwin3005 commented 1 year ago

okay.. take it @M-Rahul1

Ravina-Deogadkar commented 1 year ago

I already started working on it

ashwin3005 commented 1 year ago

Okay. no problem. Make a pull request while you are done..

Ravina-Deogadkar commented 1 year ago

Created pull request

https://github.com/ashwin3005/password-generator/pull/47

ashwin3005 commented 1 year ago

So that now it is made default, but the lowercase is not excluded if we uncheck it..

Ravina-Deogadkar commented 1 year ago

Fixed it https://github.com/ashwin3005/password-generator/pull/49

M-Rahul1 commented 1 year ago

Is it completed? @ashwin3005

ashwin3005 commented 1 year ago

yeah