Dark Mode CSS Bug Fix - Githubissues

gkelley commented 2 years ago

In darkmode on a large screen the container color does not fill the screen:

My fix will allow for full screen filling of the color

netlify[bot] commented 2 years ago

Name	Link
Latest commit	b9df03756699d21c8804207ca69440eb831c2110
Latest deploy log	https://app.netlify.com/sites/create-your-password/deploys/6343080726059b0009a621c0
Deploy Preview	https://deploy-preview-48--create-your-password.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ashwin3005 commented 2 years ago

what changes have you made?

gkelley commented 2 years ago

@ashwin3005 Just updated the description!

ashwin3005 commented 2 years ago

Thanks a lot for contributing.

gkelley commented 2 years ago

@ashwin3005 I am seeing some compilation errors when running locally:

Compiler.js:1196 hooks.afterCompile.callAsync.err [password-generator]/[webpack]/lib/Compiler.js:1196:17
Hook.js:18 Hook.CALL_ASYNC_DELEGATE [as _callAsync] [password-generator]/[tapable]/lib/Hook.js:18:14
Compiler.js:1192 compilation.seal.err [password-generator]/[webpack]/lib/Compiler.js:1192:33
Compilation.js:2787 finalCallback [password-generator]/[webpack]/lib/Compilation.js:2787:11
Compilation.js:3092 hooks.afterSeal.callAsync.err [password-generator]/[webpack]/lib/Compilation.js:3092:11

1 ERROR in child compilations (Use 'stats.children: true' resp. '--stats-children' for more details) webpack compiled with 3 errors

Have you seen this?

ashwin3005 / password-generator