search

ashwin3005 / password-generator

Password generator made with React
MIT License
20 stars 38 forks source link

Replaced Math.random #69

Closed wavpro closed 1 year ago

wavpro commented 1 year ago

Math.random should never be used for generating passwords due to being predictable. Even at low scale, it's not good practice. Replaced it with a Crypto.getRandomValues solution instead.

netlify[bot] commented 1 year ago

Deploy Preview for create-your-password ready!

Name Link
Latest commit 47a8b5f5c2d4213939a441975f5c3be40376890a
Latest deploy log https://app.netlify.com/sites/create-your-password/deploys/63550274f17d6f00083e554b
Deploy Preview https://deploy-preview-69--create-your-password.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ashwin3005 commented 1 year ago

This reduces the randomness, I don't know why.

you can see the difference,

After change:

Screencast from 23-10-22 05:09:49 PM IST.webm

Before change:

Screencast from 23-10-22 05:12:13 PM IST.webm

you could notice after changing few times the symbols are not included.

wavpro commented 1 year ago

I'll look into it