ashwin3005 / password-generator

Password generator made with React
MIT License
21 stars 38 forks source link

fixed strength checker terms displayed for password #78

Closed hrithiksawhney closed 2 years ago

hrithiksawhney commented 2 years ago

Fixes #10

Currently, the strength terms displayed are: Fair (8), Good (9-10), Strong (11-32)

After my changes, the strength terms displayed are: Weak (4-6), Fair (7-8), Good (9-10), Strong (11-32)

netlify[bot] commented 2 years ago

Deploy Preview for create-your-password ready!

Name Link
Latest commit 7d6a2b88956fa8d88f6700d6d3f25de26754b483
Latest deploy log https://app.netlify.com/sites/create-your-password/deploys/6359755c847aa3000a800502
Deploy Preview https://deploy-preview-78--create-your-password.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ashwin3005 commented 2 years ago

Thanks for contributing.

Give us a star if you like.

ashwin3005 commented 2 years ago

Minimum length of 4 is fine.

can you make, 8 as the default value?

hrithiksawhney commented 2 years ago

Sure @ashwin3005. PR for the same: https://github.com/ashwin3005/password-generator/pull/80